Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): register metrics via callback #1062

Merged
merged 1 commit into from
May 14, 2024

Conversation

SuperFluffy
Copy link
Member

Summary

Register metrics for a service through a callback on the telemetry builder.

Background

astria_telemetry::Config should be the central entry point to configure telemetry and metrics. Before this patch the metrics provider, buckets, and global labels were set through config, but actual metrics specific outside of it. With this patch this is done in one step.

Changes

  • add Config::register_metrics on telemetry builder
  • change all services to pass their initialization function to it.

Testing

Must be observed in a dev cluster.

@SuperFluffy SuperFluffy requested a review from a team as a code owner May 9, 2024 15:59
@SuperFluffy SuperFluffy requested a review from Fraser999 May 9, 2024 15:59
@github-actions github-actions bot added conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer labels May 9, 2024
@SuperFluffy SuperFluffy added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6ceb3f9 May 14, 2024
36 checks passed
@SuperFluffy SuperFluffy deleted the superfluffy/register_metrics branch May 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer pertaining to composer conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants