feat(telemetry): register metrics via callback #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Register metrics for a service through a callback on the telemetry builder.
Background
astria_telemetry::Config
should be the central entry point to configure telemetry and metrics. Before this patch the metrics provider, buckets, and global labels were set through config, but actual metrics specific outside of it. With this patch this is done in one step.Changes
Config::register_metrics
on telemetry builderTesting
Must be observed in a dev cluster.