fix(sequencer): fix ibc prefix conversion #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steezeburger
approved these changes
May 11, 2024
SuperFluffy
approved these changes
May 13, 2024
| @@ -244,7 +244,13 @@ impl AppHandlerExecute for Ics20Transfer { | |||
| .await | |||
| { | |||
| Ok(()) => TokenTransferAcknowledgement::success(), | |||
| Err(e) => TokenTransferAcknowledgement::Error(e.to_string()), | |||
| Err(e) => { | |||
| tracing::debug!( | |||
There was a problem hiding this comment.
I wonder if this should be elevated to info!
There was a problem hiding this comment.
probably not, as we could potentially see this often, users can trigger this by sending invalid transfers to astria
| dest_port: &PortId, | ||
| dest_channel: &ChannelId, | ||
| is_refund: bool, | ||
| ) -> Denom { |
There was a problem hiding this comment.
looking at how you use this this might be a use case for Cow<'a, Denom> with Cow::Borrowed(&'a Denom) if is_refund and Cow::Owned(Denom) otherwise.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prefixes were not being converted correctly for bridge locks, i refactored the ibc prefix conversion to be in its own function and added unit tests for all cases.
Background
found while testing incoming ibc transfers to a bridge account, the denom was not being prefixed before being compared to the allowed asset ID for the bridge account.
Changes
convert_denominationfunctionexecute_ics20_transfer, so the correct converted denom should be usedTesting
unit tests + tested it with a bridge lock via ibc