-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(composer)! avoid holding private key in env var #1074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the changes.
Can we also put the SigningKey
behind a https://docs.rs/secrecy/0.8.0/secrecy/struct.Secret.html? So that we don't accidentally leak it if someone decides to debug-print executor or the submitfut? Right now SigningKey
implements Debug
and happily leaks its contents.
@SuperFluffy - as agreed, I put the signing key in a newtype in 3515ac0 and replaced all usages of the original type. |
Summary
This PR changes the configuration env vars for composer to not hold the contents of the private key for signing sequencer transactions.
Background
It's undesirable to have the contents of a private key in an env var.
Changes
Changed the existing env var to hold a path to a hex-encoded private key file.
Testing
Modified existing tests, and ran smoke test using local build of composer.
Breaking Changelist
ASTRIA_COMPOSER_PRIVATE_KEY
ASTRIA_COMPOSER_PRIVATE_KEY_FILE
Related Issues
Closes #993.