chore(composer): Add instrumentation #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
force-pushed
the
ENG-670/add_composer_instrumentation
branch
from
ac481ff
to
a54bb2c
Compare
….com/astriaorg/astria into ENG-670/add_composer_instrumentation
Fraser999
approved these changes
Aug 28, 2024
…1361) ## Summary Shortened and streamlined geth and executor `run_until_stopped()` functions to get rid of clippy exceptions and ensure events are emitted within spans. ## Background #1326 removed instrumentation on these `run_until_stopped()` functions, which revealed a clippy warning for too many lines. Additionally, this made it so that logging inside these functions would not be emitted within any span. ## Changes - Delegated many tasks to helper functions with instrumentation. - Created new `utils` module to house a shared `report_exit_reason()` function. - Moved `ensure_chain_id_is_correct()` and `get_latest_nonce()` to `init()` (previosuly `pre_run_checks()`) ## Testing Passing all tests. ## Related Issues Part of #1321 --------- Co-authored-by: Fraser Hutchison <[email protected]> Co-authored-by: Richard Janis Goldschmidt <[email protected]>
steezeburger
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added instrumentation to
astria-composerBackground
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
Related Issues
Part of #1321