chore(conductor): Add instrumentation #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
force-pushed
the
ENG-670/add_conductor_instrumentation
branch
from
5863be9
to
eb0e958
Compare
Fraser999
reviewed
Aug 28, 2024
Co-authored-by: Fraser Hutchison <[email protected]>
Fraser999
approved these changes
Aug 30, 2024
steezeburger
added a commit
that referenced
this pull request
Sep 3, 2024
* main: chore: ibc e2e smoke test (#1284) chore(metrics): restrict `metrics` crate usage to `astria-telemetry` (#1192) fix(charts)!: sequencer-relayer chart correct startup env var (#1437) chore(bridge-withdrawer): Add instrumentation (#1324) chore(conductor): Add instrumentation (#1330) fix(cli, bridge-withdrawer): dont fail entire block due to bad withdraw event (#1409) feat(sequencer, bridge-withdrawer)!: enforce withdrawals consumed (#1391)
jbowen93
pushed a commit
that referenced
this pull request
Sep 3, 2024
## Summary Added instrumentation to `astria-conductor` ## Background Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them. ## Changes - Added instrumentation to all async function calls that are not long-lived. - Added instrumentation on some non-async functions that utilize logging such that logging occurs within a span. - Removed instrumentation on `run_until_stopped()` functions. - Minor refactoring of `run_until_stopped()` functions to ensure logging occurs within spans. ## Related Issues Part of #1321 --------- Co-authored-by: Fraser Hutchison <[email protected]>
jbowen93
pushed a commit
that referenced
this pull request
Sep 6, 2024
## Summary Added instrumentation to `astria-conductor` ## Background Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them. ## Changes - Added instrumentation to all async function calls that are not long-lived. - Added instrumentation on some non-async functions that utilize logging such that logging occurs within a span. - Removed instrumentation on `run_until_stopped()` functions. - Minor refactoring of `run_until_stopped()` functions to ensure logging occurs within spans. ## Related Issues Part of #1321 --------- Co-authored-by: Fraser Hutchison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added instrumentation to
astria-conductorBackground
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
run_until_stopped()functions.run_until_stopped()functions to ensure logging occurs within spans.Related Issues
Part of #1321