-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trusted Builder MVP(W.I.P) #1356
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conductor
pertaining to the astria-conductor crate
proto
pertaining to the Astria Protobuf spec
sequencer
pertaining to the astria-sequencer crate
composer
pertaining to composer
cd
labels
Aug 7, 2024
bharath-123
force-pushed
the
bharath/composer-execution-api-integration
branch
from
August 13, 2024 10:58
acec62b
to
ef45ebd
Compare
bharath-123
force-pushed
the
bharath/composer-execution-api-integration
branch
from
August 20, 2024 07:55
b708e5f
to
051735f
Compare
quasystaty1
added
preview
demo
docker-build
used to trigger docker builds on PRs
labels
Aug 20, 2024
bharath-123
force-pushed
the
bharath/composer-execution-api-integration
branch
from
September 6, 2024 15:33
36e4abd
to
0f07816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR describes the changes made to the composer and conductor for the Trusted Builder MVP.
Background
A Trusted Builder is a sophisticated rollup entity who is responsible for creating high value bundles. Composer is part of the trusted builder. The trusted builder's composer is responsible for simulating the bundle created by the builder and removing any invalid or reverting txs. To achieve this, we have made changes to the ExecuteBlock method/ to have a simulateOnly mode and to return txs that have been successfully included in a block.
More details on Trusted Builder are included in https://www.notion.so/astria-org/Trusted-Block-Builder-MVP-8eba7cd7cbd34e4e90a4adf726879028?pvs=4
Changes
ExecuteBlock
method to take in a fieldsimulateOnly
which indicates that theExecuteBlock
run is only for simulation.ExecuteBlock
method to return the included transactions list along with the returned block.BundleSimulator
type which is responsible for simulating a given bundle. To simulate, we callGetCommitmentState
followed by anExecuteBlock
withsimulateOnly
as true. We then create aBuilderBundlePacket
with the included transactions and submit it to the sequencer.ExecutionAPI
protos and add some boilerplate for theBuilderBundle
andBuilderBundlePacket
protos to convert it from the raw protobuf and the original struct.Testing
Modifying Unit tests.
Deploying locally and running spamooor against it.
Related Issues
#1322
closes