Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): increase rpc.gascap #1445

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(charts): increase rpc.gascap #1445

wants to merge 4 commits into from

Conversation

mycodecrafting
Copy link
Contributor

Summary

Increase rpc.gascap to 550M

Background

The default rpc gas cap for read only rpc ops (eth_estimateGas and eth_call) is quite low (50M). Many infra providers set this much higher (Infura @ 300M and Alchemy @ 550M). Some protocols and contract views require a higher setting to function correctly, e.g, Uniswap V3 requires at least 150M for its off chain router.

Changes

  • Increased rpc.gascap to from 50M 550M

Testing

N/A changing standard geth flag

@mycodecrafting mycodecrafting requested a review from a team as a code owner September 4, 2024 13:19
@github-actions github-actions bot added the cd label Sep 4, 2024
# Configure the gas Limit
gasLimit: "50000000"
# Configure the gas Limit for rpc read only ops (eth_estimateGas and eth_call)
gasLimit: "550000000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question for me, this is already a value on the chart, so it's easily configurable. This is effectively changing the default. Do we change the default or do we just want to edit on a per deployment basis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good question and leads me to realize we are using the gasLimit value for 2 different things.

  1. for the gasLimit in genesis header. Semantically, this should match the block gas limit, which we don't currently allow to change via configuration and is hard coded to 30M. and,
  2. for the rpc.gascap flag which is a runtime flag and has nothing to do with genesis.

I propose that we:

  1. Use the genesis gasLimit value for the genesis header but update it to be semantically correct (30M), and
  2. Add rpcGasCap to config.geth in values with a default of 50M (the geth default) and can then bump it up on a per deployment basis.

Will update the PR with the above unless there is objection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can already adjust the config value via the flags which are passed into the chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants