Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add graph-node to charts. #1489

Merged
merged 20 commits into from
Sep 27, 2024
Merged

Feature: Add graph-node to charts. #1489

merged 20 commits into from
Sep 27, 2024

Conversation

sambukowski
Copy link
Contributor

Added a graph-node helm chart to the charts.

@github-actions github-actions bot added the cd label Sep 11, 2024
@sambukowski sambukowski marked this pull request as ready for review September 17, 2024 17:01
@sambukowski sambukowski requested review from a team as code owners September 17, 2024 17:01
quasystaty1
quasystaty1 reviewed Sep 20, 2024
View reviewed changes
charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/deploy.just Outdated Show resolved Hide resolved
charts/graph-node/templates/deployment.yaml Show resolved Hide resolved
charts/graph-node/templates/services.yaml Show resolved Hide resolved
charts/graph-node/values.yaml Show resolved Hide resolved
quasystaty1
quasystaty1 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@quasystaty1 quasystaty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

charts/graph-node/templates/ingress.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
joroshiba
joroshiba reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level nit, should be enforced with a linter, I can work on that. Prefer to have lists have an indent for clarity, although both are valid yaml I think it's a bit easier to read

entry:
  - item

instead of

entry:
- item

charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/persistent-volume-claims.yaml Outdated Show resolved Hide resolved
charts/graph-node/templates/services.yaml Outdated Show resolved Hide resolved
@sambukowski sambukowski added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@sambukowski sambukowski added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 77c70bf Sep 27, 2024
43 checks passed
@sambukowski sambukowski deleted the joroshiba/start-graph-node branch September 27, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroshiba joroshiba joroshiba left review comments

@quasystaty1 quasystaty1 quasystaty1 approved these changes

@Fraser999 Fraser999 Awaiting requested review from Fraser999 Fraser999 was automatically assigned from astriaorg/rust-reviewers

Assignees
No one assigned
Labels
cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambukowski @joroshiba @quasystaty1