fix(ci): easily point smoke tests to preview-env with env vars #1516
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajimal
force-pushed
the
preview-env-vars
branch
from
e5f4742
to
91e6193
Compare
aajimal
force-pushed
the
preview-env-vars
branch
from
91e6193
to
35d635e
Compare
aajimal
force-pushed
the
preview-env-vars
branch
from
35d635e
to
98b46e8
Compare
aajimal
force-pushed
the
preview-env-vars
branch
2 times, most recently
from
d58e937
to
39f7bb2
Compare
aajimal
removed
sequencer
aajimal
force-pushed
the
preview-env-vars
branch
from
39f7bb2
to
54b7afd
Compare
aajimal
changed the title
aajimal
force-pushed
the
preview-env-vars
branch
from
54b7afd
to
acde4f5
Compare
WafflesVonMaple
approved these changes
Sep 25, 2024
aajimal
force-pushed
the
preview-env-vars
branch
from
acde4f5
to
975f7ab
Compare
Ethiqque
reviewed
Sep 26, 2024
Comment on lines
+206
to
+226
| # Set env var: PR_SEQUENCER_RPC or PR to point to a remote preview environment | ||
| pr_sequencer_rpc := env("PR_SEQUENCER_RPC", env("PR", "")) | ||
| sequencer_rpc_url := if pr_sequencer_rpc == "" {"http://rpc.sequencer.localdev.me"} else {replace("http://rpc.sequencer.pr-#.dev.astria.org", "#", pr_sequencer_rpc)} |
quasystaty1
approved these changes
Sep 30, 2024
…ironment variables
aajimal
force-pushed
the
preview-env-vars
branch
from
975f7ab
to
69468d5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Point sequencer_rpc, eth_rpc, and eth_ws URLs to a PR preview environment based on environment variables. Env vars can be any of the following:
Background
Allow developers to point to pull-request preview environments based on setting environment variables before running just commands.
Changes
Testing
Manually by setting each environment variable to verify scripts properly point to the right value.