Feature(cli): Add smoke tests for cli commands #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambukowski
changed the title
quasystaty1
reviewed
Oct 4, 2024
charts/cli-test.just
Outdated
| set -e | ||
|
|
||
| # make a new account to get the address bytes | ||
| output=$(just cli-test command {{ tag }} sequencer account create) |
There was a problem hiding this comment.
Maybe should be a default address in bytes configured instead of creating an account? create account might change to print a bech32m prefixed address instead of bytes
quasystaty1
reviewed
Oct 4, 2024
charts/cli-test.just
Outdated
| command tag *ARGS: | ||
| docker run --rm --network host "ghcr.io/astriaorg/astria-cli{{ if tag != '' { replace(':#', '#', tag) } else { '' } }}" {{ ARGS }} | ||
|
|
||
| fundedAccount := "astria1rsxyjrcm255ds9euthjx6yc3vrjt9sxrm9cfgm" |
There was a problem hiding this comment.
nit: sudoAccount, but can be treated as a fundedAccount
quasystaty1
approved these changes
Oct 4, 2024
SuperFluffy
requested changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add smoke tests for all existing sequencer commands for the cli.
Tests added:
account createaddress bech32maccount balancebalance getaccount nonceblockheight getsudo ibc-relayer addsudo ibc-relayer removesudo fee-asset addsudo fee-asset removesudo sudo-address-changesudo validator-updatetransfer┆Issue Number: ENG-868
closes #1570