-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(proto): move optimistic block protos to v1 #1707
Conversation
b1711e8
to
f27c8d6
Compare
f27c8d6
to
00b2ae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auctioneer isn't shipped yet, maybe this should stay v1alpha1 for now?
The auctioneer stuff remains v1alpha1 here, it is just updated to use the correct (v1) version of everything else. |
00b2ae6
to
acc9564
Compare
acc9564
to
9a65f20
Compare
Have to push back on this naming convention. v1 sequencer block with v1alpha1 optimistic block? We should have probably not nested the optimistic block bits under sequencerblock in this way, but provided a structure like in the protocol APIs. I am not sure how to best tackle this, but I feel like going with Would like to pull @joroshiba into this. |
9a65f20
to
b9e041c
Compare
b9e041c
to
76f6587
Compare
76f6587
to
711bba5
Compare
proto/sequencerblockapis/astria/sequencerblock/optimisticblock/v1alpha1/optimistic_block.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, think this is good sane versioning for the proto. Agreed with Janis on naming service.proto
as a nit.
711bba5
to
d1edce9
Compare
d1edce9
to
4287b94
Compare
This unfortunately imports the wrong generated code and doesn't name it according to our convention. This PR should not have been merged. (It also lacks a CHANGELOG). |
Summary
This updates the protos used for the auctioneer to be based on the new v1 protos.
Background
We bumped our proto definition versions from
v1alpha_
tov1
.Changes
sequencerblock/optimistic_block
file into its own subpackage in order to havesequencerblock.optimisticblock.v1alpha1
FilteredSequencerBlock
from v1Breaking Changelist
closes #1767