Apply new storage conventions to Connect oracle #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of injected txs
Fraser999
force-pushed
the
fraser/slinky
branch
from
d0e3c4b
to
c450667
Compare
Fraser999
force-pushed
the
fraser/slinky
branch
from
c450667
to
e5164be
Compare
noot
reviewed
Nov 3, 2024
| rollup_transactions_proof, | ||
| rollup_ids_root, | ||
| rollup_ids_proof, | ||
| } = take_initial_elements_from_data(data)?; |
There was a problem hiding this comment.
note to self: need to allow this to not have the extended_commit_info as to be nonbreaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This mainly brings the new oracle code in line with storage conventions formed after the initial cut of the PR.
Background
We want a consistent approach to storage across all components. As well as using a single serialization format (Borsh), this will allow us to iterate on the storage design in the near future.
Changes
storagesubmodules to the two sequencer modulesconnect::market_mapandconnect::oracle. These provide the keys and values which are used to store the relevant data.connect::marketmapin the sequencer toconnect::market_mapTesting
Added several unit tests.
Changelogs
We should update changelogs once the feature is ready to be merged to
main. Not done in this PR.Breaking Changelist