feat(cli)!: remove default chain ID, endpoint URL #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
force-pushed
the
superfluffy/no-chain-defaults
branch
from
f1f7e40
to
410ae52
Compare
SuperFluffy
force-pushed
the
superfluffy/no-chain-defaults
branch
from
410ae52
to
5a56f75
Compare
noot
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the default RPC URL and chain IDs the CLI.
Background
It is a safety issue to interact with the wrong chain, and so these defaults should not be enshrined in the app.
Changes
--sequencer.chain-idarguments.--sequencer-urlarguments.Testing
All smoke tests already explicitly provided chain ID and RPC URL and thus keep working.
Ran manually: omitting either arguments now results in errors like this:
Changelogs
"Changelogs updated."
Breaking Changelist
astria-dusk-10at"https://rpc.sequencer.dusk-10.devnet.astria.org"no longer work. Chain ID and RPC URL now need to be set explicitly by providing an environment variable or command line argumient.Invocations that already had the chain ID and RPC URL present continue working unchanged.