Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sequencer): add unit tests for src/bridge/state_ext #878

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

Lilyjjo
Copy link
Contributor

@Lilyjjo Lilyjjo commented Mar 28, 2024

Summary

Sixth set of state-ext unit tests. In total there are seven files which
need tests:

  • astria-sequencer/src/api_state_ext.rs
  • astria-sequencer/src/state_ext.rs
  • astria-sequencer/src/accounts/state_ext.rs
  • astria-sequencer/src/asset/state_ext.rs
  • astria-sequencer/src/authority/state_ext.rs
  • astria-sequencer/src/bridge/state_ext.rs (This PR)
  • astria-sequencer/src/ibc/state_ext.rs

This PR just tests the src/bridge/state_ext.rs file.

Background

It is good to have unit tests to ensure that the database works as intended.

Changes

  • Unit tests for the functionality in the file src/bridge/state_ext.rs were added.
  • Fixed issue in get_deposit_nonce() where the returned bytes were not formatted correctly.

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Mar 28, 2024
Copy link
Collaborator

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the fix!

@Lilyjjo Lilyjjo force-pushed the lilyjjo/state-ext-unit-tests-6 branch from 4ccdd9d to c3e7853 Compare April 1, 2024 19:07
@Lilyjjo Lilyjjo merged commit f033435 into main Apr 1, 2024
35 checks passed
@Lilyjjo Lilyjjo deleted the lilyjjo/state-ext-unit-tests-6 branch April 1, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants