bump astria and penumbra deps #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
reviewed
Jul 1, 2024
crates/relayer/src/transfer.rs
Outdated
| timeout_height: Some(timeout_height), | ||
| timeout_time: timeout_timestamp.nanoseconds(), | ||
| fee_asset_id: default_native_asset_id().as_ref().to_vec(), | ||
| fee_asset: "nria".to_string(), // TODO: make this configurable |
There was a problem hiding this comment.
IMO use astria_core::primitive::v1::Asset just to make sure:
fee_asset: "nria".parse::<Denom>().expect("nria is a valid denom").to_string(),
SuperFluffy
reviewed
Jul 1, 2024
crates/relayer/src/transfer.rs
Outdated
| use astria_core::sequencer::v1::asset::default_native_asset_id; | ||
| use astria_core::primitive::v1::Address; | ||
| let sender: Address = sender | ||
| .to_string() |
There was a problem hiding this comment.
This has impl AsRef<str> for Sender, so this should work without allocation: sender.as_ref().parse(), or more explicitly AsRef::<str>::as_ref(&sender).parse() (might be necessary if it can't decide what to use as the as-ref target).
SuperFluffy
reviewed
Jul 1, 2024
| primitive::v1::Address, | ||
| }; | ||
| let verification_key = | ||
| VerificationKey::try_from(self.signing_key.verifying_key().to_bytes()) |
There was a problem hiding this comment.
You could provide a unit test to ensure that this will keep on working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.