Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching of evidence estimation inputs and update examples #307

Merged
merged 15 commits into from
Nov 5, 2024

Conversation

alicjapolanska
Copy link
Collaborator

  • Add functionality to batch samples for evidence estimation in the add_chains method to avoid memory issues.

  • Change Rosenbrock example to be able to handle arbitrary dimension and fix bugs.

  • Switch Gaussian example and plotting of realisations to log space.

harmonic/evidence.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicjapolanska A few points raised, all super small, I've approved either way whether you make these changes or not. Good stuff sorting this problem :)

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (9726ce2) to head (16b72d5).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   95.73%   95.80%   +0.06%     
==========================================
  Files          14       14              
  Lines        2298     2335      +37     
==========================================
+ Hits         2200     2237      +37     
  Misses         98       98              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alicjapolanska alicjapolanska merged commit 55c970e into main Nov 5, 2024
2 checks passed
@alicjapolanska alicjapolanska deleted the 20D_gaussian branch November 5, 2024 16:56
@alicjapolanska alicjapolanska restored the 20D_gaussian branch November 6, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants