-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batching of evidence estimation inputs and update examples #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alicjapolanska A few points raised, all super small, I've approved either way whether you make these changes or not. Good stuff sorting this problem :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 95.73% 95.80% +0.06%
==========================================
Files 14 14
Lines 2298 2335 +37
==========================================
+ Hits 2200 2237 +37
Misses 98 98
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add functionality to batch samples for evidence estimation in the
add_chains
method to avoid memory issues.Change Rosenbrock example to be able to handle arbitrary dimension and fix bugs.
Switch Gaussian example and plotting of realisations to log space.