-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native WebKit on macOS #713
Draft
c-alpha
wants to merge
13
commits into
astroidmail:master
Choose a base branch
from
c-alpha:ns-nativewebkit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauteh
force-pushed
the
ns-nativewebkit
branch
from
August 10, 2021 10:10
79f0323
to
2daa6fa
Compare
Moving the pImpl declaration near the top of the class declaration so it's easier to spot.
Making the pImpl pointer public again, because we need to use it from the "extern C" pure functions. Fix misspelled pImpl destructor declaration. Re-remove default implementation assignments for the copy ctor and the assignment operator as the compiler complains bout them.
|
Further files with webkit references are:
The next logical target would seem |
Those g_signal calls need to be made in the WebView's context, but that is now hidden in ThreadView's pImpl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKitGTK is a nightmare to build on macOS. It takes hours to compile (literally), it needs patches, and it doubles up functionality that is already available on the platform.
Hence, it would seem tempting to try to use the native WebKit that ships with the macOS platform. This is what this PR attempts.
I plan to do this in two steps:
Move anything specific to WebKitGTK from the header to the corresponding implementation file using the C++ PIMPL pattern. If everything works ok, this should produce an executable that works identically to before the refactoring.
WKWebView
on macOS.As all the public class interfaces have been freed from WebKitGtk references in the previous phase, I can start adding macOS-specific class implementations, that implement the public class interface (using ObjC++), but use a native
WKWebView
. Whether these new files, or the "standard" ones for Linux are compiled will be determined by theCMakeLists.txt
build specs.A key challenge will of course be to hook the
WKWebView
into the hierarchy of Gtk graphics objects. For sure, somewhere deep down the Gtk implementation there must be a pointer or reference to some macOS native window or similar. Perhaps I can find a way to access that, and hook theWKWebView
up with that. Fingers crossed! 🤞