Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally write out all of the parquet files. #181

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

This is part of astronomy-commons/hats#147 (in a kind of round-a-bout way).

This adds functionality to the pipeline to optionally write out all of the leaf parquet files necessary for the association table, mostly to generate a test association catalog for hipscat/lsdb. When leaf parquet files are written out, we use those footers to generate a _metadata file for the catalog. Otherwise, we artificially create the necessary metadata.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a476a8) 99.91% compared to head (221bdd1) 99.76%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/hipscat_import/soap/map_reduce.py 96.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   99.91%   99.76%   -0.16%     
==========================================
  Files          27       27              
  Lines        1164     1250      +86     
==========================================
+ Hits         1163     1247      +84     
- Misses          1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it all seems to make sense to me!

src/hipscat_import/soap/run_soap.py Outdated Show resolved Hide resolved
src/hipscat_import/soap/run_soap.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit b800040 into main Dec 6, 2023
10 of 12 checks passed
@delucchi-cmu delucchi-cmu deleted the hipscat_issue/147/leaf branch December 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants