Update size estimate on converted catalog. #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hats #402 +/- ##
=======================================
Coverage ? 99.12%
=======================================
Files ? 29
Lines ? 1606
Branches ? 0
=======================================
Hits ? 1592
Misses ? 14
Partials ? 0 ☔ View full report in Codecov by Sentry. |
gitosaurus
approved these changes
Oct 3, 2024
delucchi-cmu
added a commit
that referenced
this pull request
Oct 17, 2024
* Initial rename to HATS (#390) * Initial renaming * Couple more places. * "hats-sharded" * Remove text about healpix_29 uniqueness. * Create HiPS-style properties file (#391) * Initial work toward properties file. * Apply suggestions from code review Co-authored-by: Sandro Campos <[email protected]> * Code review comments. --------- Co-authored-by: Sandro Campos <[email protected]> * Initial pipeline for converting hipscat -> hats (#392) * Initial work toward properties file. * Initial pipeline for converting hipscat -> hats * Apply suggestions from code review Co-authored-by: Derek T. Jones <[email protected]> --------- Co-authored-by: Derek T. Jones <[email protected]> * Follow-up on run_conversion.py The `:=` operator obviates the line following, but I wasn't able to make that part of my PR suggestion. * Set new and additional properties. (#396) * Initial work toward properties file. * Initial pipeline for converting hipscat -> hats * Remove provenance, remove methods, use new constants * Set new and additional properties. * Clean up merge * Improve readability of literals. * Set additional properties on conversion (#397) * use spatial index from hats * Update size estimate on converted catalog. (#402) * Update size estimate on converted catalog. * Style cleanup and enforcement. * Whomp whomp * Reduce code duplication * Just don't bother with test files for mypy * Insert dataset dir, and use general ra/dec columns (#406) * Insert dataset dir, and use general ra/dec columns * Update src/hats_import/hipscat_conversion/run_conversion.py Co-authored-by: Sandro Campos <[email protected]> * Update deps for renamed repo --------- Co-authored-by: Sandro Campos <[email protected]> * Apply suggestions from code review Co-authored-by: Sandro Campos <[email protected]> * Remove branch from workflows --------- Co-authored-by: Sandro Campos <[email protected]> Co-authored-by: Derek T. Jones <[email protected]> Co-authored-by: Sean McGuire <[email protected]> Co-authored-by: Sean McGuire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
In the course of fixing this, I found many linting issues that have crept in over the course of this branch, because we haven't had CI running on PRs for this branch! This addresses the findings, and turns on branch CI (just in time for the very last few PRs...)