Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin fine filtering. #435

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

Temporarily remove fine filtering.

See #434

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.58%. Comparing base (9aa49c4) to head (0d47df8).
Report is 1 commits behind head on margin.

Files with missing lines Patch % Lines
...hats_import/margin_cache/margin_cache_arguments.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           margin     #435      +/-   ##
==========================================
- Coverage   98.64%   98.58%   -0.07%     
==========================================
  Files          28       28              
  Lines        1620     1620              
==========================================
- Hits         1598     1597       -1     
- Misses         22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Before [9aa49c4] After [a220ec8] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu changed the base branch from main to margin November 18, 2024 17:18
@delucchi-cmu delucchi-cmu merged commit 1c5acb5 into margin Nov 18, 2024
9 of 11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/margin/remove_fine branch November 18, 2024 17:25
delucchi-cmu added a commit that referenced this pull request Nov 26, 2024
* Remove margin fine filtering. (#435)

* Use different methods for healpix manipulation. (#436)

* Remove margin fine filtering.

* Use different methods for healpix manipulation.

* Optional dependency for older healpy fits files.

* Allow import of map types. (#437)

* Accomodate changes in cds-healpix.

* Use radec2pix for healpix pixel calculation. (#438)

* Remove default healpy dependency. (#440)

* Clean up pre-commit
delucchi-cmu added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants