Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index search and unit test data #123

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Index search and unit test data #123

merged 1 commit into from
Jan 17, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Part of issue #108 .

Adds catalog search mechanism to restrict based on values in an IndexCatalog.

Copy link

Before [2ec29db] After [04b833a] Ratio Benchmark (Parameter)
12.8±0.1ms 12.9±0.3ms 1.01 benchmarks.time_polygon_search
31.6±0.2ms 31.6±0.5ms 1 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ec29db) 98.47% compared to head (702682b) 98.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   98.47%   98.50%   +0.03%     
==========================================
  Files          31       32       +1     
  Lines         785      801      +16     
==========================================
+ Hits          773      789      +16     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested review from drewoldag and camposandro and removed request for drewoldag January 17, 2024 17:29
@delucchi-cmu delucchi-cmu merged commit 537f2ea into main Jan 17, 2024
15 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/108/search branch January 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants