Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PS1 image to ZTF-NGC NB #153

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add PS1 image to ZTF-NGC NB #153

merged 1 commit into from
Feb 9, 2024

Conversation

hombit
Copy link
Contributor

@hombit hombit commented Feb 9, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Feb 9, 2024

Before [fd60912] After [8ce68f2] Ratio Benchmark (Parameter)
32.0±0.3ms 32.3±0.5ms 1.01 benchmarks.time_kdtree_crossmatch
13.1±0.2ms 13.2±0.1ms 1.01 benchmarks.time_polygon_search

Click here to view all benchmarks.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd60912) 98.62% compared to head (8210e33) 98.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          35       35           
  Lines         873      873           
=======================================
  Hits          861      861           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit requested a review from smcguire-cmu February 9, 2024 15:24
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

@hombit hombit merged commit 178e41e into main Feb 9, 2024
15 checks passed
@hombit hombit deleted the user-docs-ps1-img branch February 9, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants