Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alignment moc in crossmatch/join operations #438

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Uses the PixelAlignment object's moc as the moc in the output catalogs of join and crossmatch operations.

Fixes #428

@smcguire-cmu smcguire-cmu marked this pull request as ready for review October 14, 2024 21:57
Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the filtered structures on search operations are also not carrying the mocs:

filtered_hc_structure = search.filter_hc_catalog(self.hc_structure)

Do you want to address it in this PR or should I open a new issue?

@smcguire-cmu
Copy link
Contributor Author

I'm pretty sure the searches do carry the mocs. The filter_hc_catalog method calls the filter_by_moc or filter_by_healpix_pixels methods in hipscat that include the filtered moc.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (ab3f57a) to head (c7dd949).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #438   +/-   ##
============================================
  Coverage        97.87%   97.87%           
============================================
  Files               44       44           
  Lines             1601     1601           
============================================
  Hits              1567     1567           
  Misses              34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right, search operations carry the MOC over if the catalog already has one! If not, we could still generate a MOC from the catalog's pixel tree. I opened issue astronomy-commons/hats#378.

Can you please point the docs hipscat to its development branch?

@smcguire-cmu smcguire-cmu merged commit 964a207 into development Oct 15, 2024
10 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/alignment-moc branch October 15, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants