-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Alignment moc in crossmatch/join operations #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the filtered structures on search operations are also not carrying the mocs:
lsdb/src/lsdb/catalog/catalog.py
Line 326 in c478401
filtered_hc_structure = search.filter_hc_catalog(self.hc_structure) |
Do you want to address it in this PR or should I open a new issue?
I'm pretty sure the searches do carry the mocs. The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #438 +/- ##
============================================
Coverage 97.87% 97.87%
============================================
Files 44 44
Lines 1601 1601
============================================
Hits 1567 1567
Misses 34 34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you're right, search operations carry the MOC over if the catalog already has one! If not, we could still generate a MOC from the catalog's pixel tree. I opened issue astronomy-commons/hats#378.
Can you please point the docs hipscat to its development branch?
Uses the
PixelAlignment
object's moc as the moc in the output catalogs of join and crossmatch operations.Fixes #428