-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update margin docs notebook to use new plotting functions #513
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## margin #513 +/- ##
=========================================
Coverage ? 97.57%
=========================================
Files ? 41
Lines ? 1610
Branches ? 0
=========================================
Hits ? 1571
Misses ? 39
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just wondering if it is possible to add a label for each set of points? When calling plot_points(c="green", marker="+", label="...")
.
Good idea! I added a legend with those to the plots |
Uses plot_pixels and plot_points instead of custom plotting function in margin tutorial.