Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update margin docs notebook to use new plotting functions #513

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

smcguire-cmu
Copy link
Contributor

Uses plot_pixels and plot_points instead of custom plotting function in margin tutorial.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (margin@d899327). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             margin     #513   +/-   ##
=========================================
  Coverage          ?   97.57%           
=========================================
  Files             ?       41           
  Lines             ?     1610           
  Branches          ?        0           
=========================================
  Hits              ?     1571           
  Misses            ?       39           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just wondering if it is possible to add a label for each set of points? When calling plot_points(c="green", marker="+", label="...").

@smcguire-cmu
Copy link
Contributor Author

Good idea! I added a legend with those to the plots

@smcguire-cmu smcguire-cmu merged commit 8269182 into margin Nov 25, 2024
9 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/margin-docs branch November 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants