Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstrings, move slow nb to pre-executed. #533

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

delucchi-cmu
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Dec 20, 2024

Before [c80c318] After [1394297] Ratio Benchmark (Parameter)
14.8±0.6ms 15.1±0.5ms 1.02 benchmarks.time_box_filter_on_partition
12.8±0.02s 12.7±0.02s 0.99 benchmarks.time_create_large_catalog
1.89±0.03s 1.87±0.01s 0.99 benchmarks.time_create_midsize_catalog
87.9±1ms 86.5±1ms 0.98 benchmarks.time_kdtree_crossmatch
29.9±0.9ms 28.7±0.4ms 0.96 benchmarks.time_polygon_search

Click here to view all benchmarks.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (c80c318) to head (85d45cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          43       43           
  Lines        1720     1720           
=======================================
  Hits         1675     1675           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from hombit December 20, 2024 18:54
@delucchi-cmu delucchi-cmu merged commit c8082b6 into main Dec 20, 2024
11 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/docs branch December 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants