Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save named indices in from_dataframe #539

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Save named indices in from_dataframe #539

merged 5 commits into from
Jan 21, 2025

Conversation

camposandro
Copy link
Collaborator

Save named indices when importing data with from_dataframe. When named indices appear in data they are usually relevant and should not be dropped, at the risk of rendering the catalog useless (e.g. if they are object/source IDs).

@camposandro camposandro self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.34%. Comparing base (a64e163) to head (f31d6b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/loaders/dataframe/from_dataframe_utils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   97.38%   97.34%   -0.05%     
==========================================
  Files          43       43              
  Lines        1724     1732       +8     
==========================================
+ Hits         1679     1686       +7     
- Misses         45       46       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 21, 2025

Before [a64e163] After [b418c00] Ratio Benchmark (Parameter)
14.4±0.4ms 14.5±0.4ms 1.01 benchmarks.time_box_filter_on_partition
12.4±0.02s 12.6±0.02s 1.01 benchmarks.time_create_large_catalog
84.6±1ms 85.1±0.7ms 1.01 benchmarks.time_kdtree_crossmatch
1.85±0.02s 1.85±0.02s 1 benchmarks.time_create_midsize_catalog
29.2±0.3ms 28.6±0.5ms 0.98 benchmarks.time_polygon_search

Click here to view all benchmarks.

@camposandro camposandro merged commit 1c5c44f into main Jan 21, 2025
9 of 11 checks passed
@camposandro camposandro deleted the rubin_index branch January 21, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants