Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/540/docs updates #542

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue/540/docs updates #542

wants to merge 5 commits into from

Conversation

OliviaLynn
Copy link
Member

Added examples to Catalog's assign docstring, to help users who are less familiar with Dask's assign
Minor spelling/formatting/grammar updates

for #540

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (abfeb5d) to head (48ff75c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files          43       43           
  Lines        1732     1732           
=======================================
  Hits         1686     1686           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2025

Before [abfeb5d] After [a235b0b] Ratio Benchmark (Parameter)
85.7±2ms 88.5±1ms 1.03 benchmarks.time_kdtree_crossmatch
29.9±1ms 30.7±1ms 1.03 benchmarks.time_polygon_search
12.7±0.06s 12.7±0.08s 1 benchmarks.time_create_large_catalog
1.91±0.02s 1.90±0.05s 0.99 benchmarks.time_create_midsize_catalog
15.3±0.5ms 15.0±0.5ms 0.98 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

catalog = Catalog(...)
catalog = catalog.assign(new_col=lambda df: df['existing_col'] * 2)
Add a column from a 1-D Dask array:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add a column from a 1-D Dask array:
Add a column from a 1-D Dask array::

Needed here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants