Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RepresentationConverter for new class paths in astropy dev #181

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

braingram
Copy link
Contributor

@braingram braingram commented May 23, 2023

Astropy recently moved a few classes:

astropy/astropy#14792
moved several classes previously in astropy.coordinates.representation to submodules. This broke the RepresentationConverter. This PR adds the new class paths (and retains the old ones for backwards compatibility).

astropy/astropy#14763
moved several Geodetic classes into astropy.coordinates.representation. The __all__ of this module is used within the asdf-astropy tests to collect classes to test the RepresentationConverter. It does not appear that these Geodetic classes are currently supported by asdf-astropy so the test was updated to ignore these classes from the list of classes to test.

@braingram
Copy link
Contributor Author

@nden I am unable to request reviewers but this should address the test-dev failure in gwcs (see: spacetelescope/gwcs#454 (comment))

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #181 (f82047e) into main (8bf5fb1) will increase coverage by 0.78%.
The diff coverage is 100.00%.

❗ Current head f82047e differs from pull request most recent head e032601. Consider uploading reports for the commit e032601 to get more accurate results

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   98.63%   99.41%   +0.78%     
==========================================
  Files          55       55              
  Lines        2047     2051       +4     
==========================================
+ Hits         2019     2039      +20     
+ Misses         28       12      -16     
Impacted Files Coverage Δ
...f_astropy/converters/coordinates/representation.py 100.00% <ø> (ø)
asdf_astropy/integration.py 100.00% <ø> (ø)
asdf_astropy/extensions.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be on hold until an asdf-coordinates-schemas release supporting this is made.

pyproject.toml Outdated Show resolved Hide resolved
@braingram
Copy link
Contributor Author

@WilliamJamieson Can we split this into 2 PRs?

  1. addressing the move of already supported classes to astropy.coordinates.representation submodules
  2. adding support for Geodetic coordinate representations (as you noted this will have to wait for updates to asdf-coordinates-schemas)

@WilliamJamieson
Copy link
Contributor

@WilliamJamieson Can we split this into 2 PRs?

  1. addressing the move of already supported classes to astropy.coordinates.representation submodules
  2. adding support for Geodetic coordinate representations (as you noted this will have to wait for updates to asdf-coordinates-schemas)

You are welcome to do whatever you want.

@braingram braingram force-pushed the upstream_class_reorg branch 2 times, most recently from 67925fe to bd77ca9 Compare May 23, 2023 20:41
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The Geodetic classes are not released yet as far as I can tell. They can be added later. @WilliamJamieson Do you have any other concerns about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants