-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RepresentationConverter
for new class paths in astropy dev
#181
Conversation
@nden I am unable to request reviewers but this should address the |
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 98.63% 99.41% +0.78%
==========================================
Files 55 55
Lines 2047 2051 +4
==========================================
+ Hits 2019 2039 +20
+ Misses 28 12 -16
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asdf_astropy/converters/coordinates/tests/test_representation.py
Outdated
Show resolved
Hide resolved
asdf_astropy/converters/coordinates/tests/test_representation.py
Outdated
Show resolved
Hide resolved
2b86997
to
67925fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be on hold until an asdf-coordinates-schemas
release supporting this is made.
@WilliamJamieson Can we split this into 2 PRs?
|
You are welcome to do whatever you want. |
67925fe
to
bd77ca9
Compare
bd77ca9
to
e032601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The Geodetic classes are not released yet as far as I can tell. They can be added later. @WilliamJamieson Do you have any other concerns about this PR?
Astropy recently moved a few classes:
astropy/astropy#14792
moved several classes previously in
astropy.coordinates.representation
to submodules. This broke theRepresentationConverter
. This PR adds the new class paths (and retains the old ones for backwards compatibility).astropy/astropy#14763moved several
Geodetic
classes intoastropy.coordinates.representation
. The__all__
of this module is used within the asdf-astropy tests to collect classes to test theRepresentationConverter
. It does not appear that theseGeodetic
classes are currently supported by asdf-astropy so the test was updated to ignore these classes from the list of classes to test.