Update copy usage in Quantity converter to deal with astropy 6.1 changes
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
changed the title
copy usage in Quantity converter to deal with astropy 6.1 changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 98.63% 97.94% -0.69%
==========================================
Files 54 54
Lines 2044 2046 +2
==========================================
- Hits 2016 2004 -12
- Misses 28 42 +14 ☔ View full report in Codecov by Sentry. |
braingram
added a commit
to braingram/asdf-astropy
that referenced
this pull request
Apr 5, 2024
Update `copy` usage in `Quantity` converter to deal with astropy 6.1 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astropy 6.1 changed the behavior of
copy:astropy/astropy#16198
This breaks the
Quantityconverter and was not caught due to thedevdepstesting against astropy "nightlies" which haven't been updated.This PR adds a version check against numpy since that is the core source of the error (it looks like astropy will just pass es through
copytoarrayinstead of selectively callingasarray).This PR also updates the CI to:
predepsjob that runs against pre-releasesThe masked array failure in the
predepsshould be fixed by:asdf-format/asdf#1769
which has not yet been released.