Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove astropy version check #237

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

ViciousEagle03
Copy link
Contributor

The minimum required version of astropy is 5.2.

"astropy>=5.2.0",

This PR removes the if check for the following:

Originally discussed: #235

@ViciousEagle03
Copy link
Contributor Author

ViciousEagle03 commented Jul 24, 2024

Do I need to add a changelog entry?

Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once the CI goes green I'll merge this and hopefully that should allow the CI to run on your other PR.

I secretly did this so you'd clean up this code :) (just kidding)

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (e686404) to head (d63bc9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   97.90%   97.90%   -0.01%     
==========================================
  Files          54       54              
  Lines        2055     2053       -2     
==========================================
- Hits         2012     2010       -2     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit fa5f1f4 into astropy:main Jul 24, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants