Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check strings for matching enum variants which can be passed in from variables #14

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhendrie91
Copy link
Collaborator

…variables

@jamesbirtles
Copy link
Contributor

Ran into this, is there anything holding this back?

@dhendrie91
Copy link
Collaborator Author

@jamesbirtles so this fix works (we've been running it in production since I submitted this PR) however it means Graphgate isn't fully spec compliant as it will try and process any string to a matching enum variant, not just ones passed as a variable, in practice this isn't really an issue. Been meaning to take a look at it again to get it, but from what I remember it's tricky as we lose the context for values at the point the enum check is carried out, so we don't know if an argument is just a string or a string passed in as a variable, so this would need a bigger fix. Will hopefully get another look at this very soon

@dhendrie91
Copy link
Collaborator Author

@sunli829 do you have any opinions on the above comments ?

@Jonatthu
Copy link

@dhendrie91 @jamesbirtles any updates on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants