Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the command to install the component #629

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

m1ner79
Copy link

@m1ner79 m1ner79 commented Jul 28, 2022

I was using the original command npm install --save @asyncapi/react-component when doing research for my article and I had some issues which were resolved but only when I requested senior dev to look at it.

It is more likely due to my inexperience but there are other junior developers like myself who may not know to use npm install --save @asyncapi/react-component@next command.

To make juniors life easier, may I ask to merge this request into your branch?

Thank you.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@magicmatatjahu magicmatatjahu changed the title update the command to install the component docs: update the command to install the component Jul 28, 2022
@magicmatatjahu
Copy link
Member

@m1ner79 Right, good catch! Can't believe we had such a big bug in docs 🤦🏼‍♂️ Thanks a lot!

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Jul 28, 2022

@m1ner79 One additional thing, could you also update that installation guide https://github.com/asyncapi/asyncapi-react/blob/next/docs/usage/web-component.md#installation to the:

npm install --save @asyncapi/web-component@next

Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@m1ner79
Copy link
Author

m1ner79 commented Jul 28, 2022

@m1ner79 One additional thing, could you also update that installation guide https://github.com/asyncapi/asyncapi-react/blob/next/docs/usage/web-component.md#installation to the:

npm install --save @asyncapi/web-component@next

Thanks!

That's now done, as per request.

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m1ner79 LGTM! Thanks very much for PR! :)

@magicmatatjahu
Copy link
Member

/rtm

@magicmatatjahu magicmatatjahu merged commit b507312 into asyncapi:next Jul 29, 2022
@magicmatatjahu
Copy link
Member

@all-contributors add @m1ner79 for docs

@allcontributors
Copy link
Contributor

@magicmatatjahu

I've put up a pull request to add @m1ner79! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.41 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants