Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render schema title if it exists #877

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

kennethaasan
Copy link
Contributor

Description

Changes proposed in this pull request:

Related issue(s)

Fixes bug introduced in #744

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kennethaasan
Copy link
Contributor Author

@jonaslagoni @derberg, please review.

@jonaslagoni
Copy link
Member

@kennethaasan I am not codeowner here 🙂

@kennethaasan
Copy link
Contributor Author

@jonaslagoni, ups sorry.

@magicmatatjahu @derberg @fmvilas, please review. This blocks us from upgrading asyncapi-react.

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kennethaasan
Copy link
Contributor Author

/rtm

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kennethaasan
Copy link
Contributor Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 9b73229 into asyncapi:master Feb 1, 2024
11 checks passed
@kennethaasan kennethaasan deleted the fix-applicatorSchemaName branch February 1, 2024 14:53
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants