Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade prettier and format code accordingly #997

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

kennethaasan
Copy link
Contributor

Description

Changes proposed in this pull request:

  • upgrade prettier and format code accordingly

Related issue(s)

See also #891

@kennethaasan kennethaasan marked this pull request as ready for review April 24, 2024 07:23
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@kennethaasan
Copy link
Contributor Author

@derberg @jonaslagoni, there are some diffs between https://github.com/asyncapi/modelina/blob/next/.prettierrc and https://github.com/asyncapi/asyncapi-react/blob/master/.prettierrc. Perhaps we should take the chance to streamline formatting across AsyncAPI projects?

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennethaasan yeah, it is the same with eslint. There are ideas, just noone here that can drive cross project initiatives. Try to reach wg-maintainers-growth in slack, maybe this is a topic for them - maybe unification of these lowers maintenance complexity

@derberg
Copy link
Member

derberg commented Apr 24, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit ed66855 into asyncapi:master Apr 24, 2024
18 checks passed
@kennethaasan kennethaasan deleted the prettier branch April 24, 2024 07:49
@jonaslagoni
Copy link
Member

@kennethaasan not a bad suggestion, if possible 👍

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.4.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants