Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content aligned in mobile view #407

Closed
wants to merge 9 commits into from

Conversation

Aryan4884
Copy link
Contributor

@Aryan4884 Aryan4884 commented Oct 2, 2024

#345
This PR addresses the issue of text alignment within the Dropdown component. Previously, the text was left-aligned on smaller screens, which affected the overall user experience.

Changes Made:
Previously:

{active}
{/* Center the button text /}
After Change:
{active}
{/
Center the button text */}

Previously:
Screenshot 2024-10-03 114349
After change:
Screenshot 2024-10-03 114506

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7512d85
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/671759335e88190008207b39
😎 Deploy Preview https://deploy-preview-407--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Collaborator

Hey @Aryan4884 could you please include the screenshots of the changes that you have made.

@Aryan4884
Copy link
Contributor Author

Aryan4884 commented Oct 3, 2024

@ashmit-coder uploaded the screenshots

@ashmit-coder
Copy link
Collaborator

Hey @Mayaleeeee What do you think about this design change?

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aryan4884 i honestly don't see a reason for this enhancement cuz it works perfectly and the only suggested improvement is the arrow rotation and color, don't you think? 🤷🏽‍♂️

@Aryan4884
Copy link
Contributor Author

Aryan4884 commented Oct 10, 2024

@AceTheCreator Yes, it works perfectly fine.But the aligned text in the mobile view just looks better somehow.

@ashmit-coder
Copy link
Collaborator

@Aryan4884 i honestly don't see a reason for this enhancement cuz it works perfectly and the only suggested improvement is the arrow rotation and color, don't you think? 🤷🏽‍♂️

So are we moving ahead with these changes?

@AceTheCreator
Copy link
Member

@AceTheCreator Yes, it works perfectly fine.But the aligned text in the mobile view just looks better somehow.

Hmm... I beg to differ

@Mayaleeeee your thoughts?

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we have on the website looks great.👌👍

We don't need these changes.

cc @ashmit-coder @AceTheCreator

@AceTheCreator
Copy link
Member

@Aryan4884 i'm closing this PR :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants