fix: parameter conversion for v3

[jonaslagoni]

Description
This PR fixes the last problem, parameter conversion to the new object that was left over from #180

Related issue(s)
Fixes #110

[jonaslagoni]

That was quick, thanks @derberg 🙇

[jonaslagoni]

/rtm

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jonaslagoni]

Nice catch @magicmatatjahu 😆

[magicmatatjahu]

I wonder how to treat all stuff like minLength etc in schema, as extension with x- prefix or skip/leave it?

[jonaslagoni]

I wonder how to treat all stuff like minLength etc in schema, as extension with x- prefix or skip/leave it?

@magicmatatjahu I would say we should make the users decide that, see if anyone complains down the road.

If we receive complains, then it might be that it should be included in the spec as well, not explicitly in the converter. Because that means users use them, when we assumed they did not.

Or we can always add it as an option or something else.

[magicmatatjahu]

@jonaslagoni Sure, I agree, also we can even add option to convert function to leave original schema as x-original-schema extension

[jonaslagoni]

Also an option yea 👍

But the spec assumes these properties are not used at all (why they are not present in the new parameter object), so I don't think it makes sense to assume it here in the tool 🙂

[jonaslagoni]

Mind making the final review @magicmatatjahu? 🙏

[magicmatatjahu]

LGTM!

[jonaslagoni]

Thank you @magicmatatjahu 🙇

[jonaslagoni]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀