chore: add gleequore package and adapters #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
requested review from
Souvikns,
KhudaDad414 and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 796434a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fmvilas
commented
Oct 28, 2024
|
|
||
| # Ignore all duplicated code as it will be removed once we replace Glee's core with GleeQuore | ||
| sonar.cpd.exclusions=packages/glee/src/adapters/**/*,packages/*-adapter/**/*,packages/shared-utils/**/*,packages/gleequore/**/* |
There was a problem hiding this comment.
❗ Attention: this is a temporary but important change. Since we're in an intermediate step where lots of code is duplicated, Sonar is complaining. I'm adding this here for now but should be removed once we replace Glee's core with GleeQuore.
Souvikns
previously approved these changes
Oct 28, 2024
|
fmvilas
changed the title
Souvikns
approved these changes
Oct 28, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the GleeQuore package, which will eventually become the "core" of Glee, and all the adapters. Paves the way for #795.