Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json serialization equals not working #1482

Conversation

JFCote
Copy link
Contributor

@JFCote JFCote commented Aug 18, 2023

Description

When using serialization with Json with capital letters, it was not working. I fix it by ignoring case during the comparison.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 1378ba7
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/64df8054a99d3e00088945c4
😎 Deploy Preview https://deploy-preview-1482--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member

@JFCote what is the input where this is not working?

Cause the unconstrainedPropertyName should be the expected value for the property when serialized and deserialized. In theory this logic you added should be unnecessary.

Cause if you have the following input:

{
  "type": "object",
  "properties": {
    "NumberPropWithCapitalCase": {
      "type": "number"
    }
}

It currently correctly checks for if (propertyName == "NumberPropWithCapitalCase").

@JFCote
Copy link
Contributor Author

JFCote commented Aug 18, 2023

Cancelling! Code 18!

@JFCote JFCote closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants