Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add options as parameter to constraints #1667

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Dec 19, 2023

Description
This PR adds options as part of the constraint callbacks so you have direct access to them when the models are being constrained, i.e. for conditionally changing the behavior.

This is only a breaking change if you use the current constraint types in TS integrations.

Related issue(s)
Part of solving #1475

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit 2d492f6
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/658146d43b262b00088c6985
😎 Deploy Preview https://deploy-preview-1667--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -55,7 +56,7 @@
"no-empty-character-class": 2,
"no-self-compare": 2,
"valid-typeof": 2,
"no-unused-vars": 0,
"unused-imports/no-unused-imports": 2,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change lint rule because the old one did not understand --fix option

Copy link
Collaborator

@kennethaasan kennethaasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Samridhi-98 Samridhi-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Collaborator

@Ferror Ferror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP ok

@jonaslagoni
Copy link
Member Author

Thanks for the review folks 🙇

@jonaslagoni jonaslagoni merged commit 396dd69 into asyncapi:next Dec 26, 2023
41 of 46 checks passed
@jonaslagoni jonaslagoni deleted the add_raw_properties_typescript branch December 26, 2023 05:56
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

jonaslagoni added a commit that referenced this pull request Feb 1, 2024
* feat!: convert to use multi parser (#1587)
* feat!: adds support for duration in java (#1604)
* feat: enable AsyncAPI v3 (#1600)
* fix!: add csharp support for DateTime, TimeSpan, Guid (#1612)
* feat!: adds extend in common, meta, and constrained models (#1613)
* feat!: adds inheritance with interfaces for java (#1593)
* chore: remove duplicate version entry for AsyncAPI processor (#1609)
* feat!: render python union in pydantic in the pre 3.10 way (#1626)
* feat: add file path as input (#1601)
* feat!: add options as parameter to constraints (#1667)
* fix: (un)marshalling tuple and dictionary unwrapping for Typescript (#1717)
* fix: jsonbinpack preset and runtime tests (#1718)
* chore: fix linting
* chore: remove unused directory
* feat!: add useJavascriptReservedKeywords option for TS (#1727)
* feat: enable raw properties for interface (#1729)
* fix: newtonsoft could not handle enum values (#1731)
* chore: update Java runtime tests (#1739)
* fix: edge case where references was incorrect handled for JSON Schema (#1754)
* fix: recursion bug for get nearest dependencies (#1757)

---------

Co-authored-by: Kenneth Aasan <[email protected]>
Co-authored-by: jano-petras <[email protected]>
Co-authored-by: Nilkanth Parmar <[email protected]>
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants