Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: expand format for integer types for C# #2054

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

jespitae
Copy link

@jespitae jespitae commented Jun 20, 2024

Description

Added extra constraints for integer types in the C# generator so int64 format results in long types.

Related Issue

Fixes #2053

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 19bdea1
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/667409f6980eff0008317688

@jespitae jespitae changed the title Take into account format for integer types. Take into account format for integer types in the C# generator Jun 20, 2024
@jonaslagoni jonaslagoni changed the title Take into account format for integer types in the C# generator feat: expand format for integer types for C# Jun 20, 2024
@jonaslagoni jonaslagoni self-requested a review June 20, 2024 10:24
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you run npm run lint:fix 🙂

@jonaslagoni jonaslagoni changed the title feat: expand format for integer types for C# feat!: expand format for integer types for C# Jun 21, 2024
@jonaslagoni jonaslagoni merged commit e717c00 into asyncapi:next Jun 21, 2024
16 of 17 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @jespitae for code, test

Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @jespitae! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.51 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants