Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding unit tests for form and slack folders #1775

Merged
merged 26 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
088daad
adding tests for both components
reachaadrika Jun 12, 2023
1974d17
Merge branch 'master' into form_tests
reachaadrika Jun 13, 2023
03a1ab3
Merge branch 'master' into form_tests
reachaadrika Jun 15, 2023
5eb0cbe
Merge branch 'master' into form_tests
reachaadrika Jun 17, 2023
75cee21
Merge branch 'master' into form_tests
reachaadrika Jun 17, 2023
cbc26d0
Merge branch 'master' into form_tests
reachaadrika Jun 18, 2023
d5e6ac2
Merge branch 'master' of https://github.com/reachaadrika/website into…
reachaadrika Jun 18, 2023
0a46499
Merge branch 'form_tests' of https://github.com/reachaadrika/website …
reachaadrika Jun 18, 2023
4201220
fix names and test-ids for consistency
reachaadrika Jun 18, 2023
a09d3bb
Merge branch 'master' of https://github.com/reachaadrika/website into…
reachaadrika Jun 19, 2023
2fab661
Merge branch 'master' into form_tests
reachaadrika Jun 21, 2023
e9c3fba
Merge branch 'master' into form_tests
reachaadrika Jun 22, 2023
6a7278d
Merge branch 'master' into form_tests
reachaadrika Jun 23, 2023
5ac4eb2
Merge branch 'master' into form_tests
reachaadrika Jun 27, 2023
f9dd4b1
Merge branch 'master' into form_tests
reachaadrika Jun 30, 2023
9f128ec
Merge branch 'master' into form_tests
reachaadrika Jul 7, 2023
1118e07
Merge branch 'master' into form_tests
reachaadrika Jul 8, 2023
2b15a06
Update cypress/test/slack/index.cy.js
reachaadrika Jul 8, 2023
3570ce5
test-id addition
reachaadrika Jul 8, 2023
98b696e
Merge branch 'master' into form_tests
reachaadrika Jul 8, 2023
6f54585
Merge branch 'form_tests' of https://github.com/reachaadrika/website …
reachaadrika Jul 8, 2023
6eca29e
add avatar check
reachaadrika Jul 8, 2023
bd59003
delete file for renaming
reachaadrika Jul 9, 2023
5509480
renamed the file Message.cy.js
reachaadrika Jul 9, 2023
ac6f7c9
Merge branch 'master' into form_tests
reachaadrika Jul 10, 2023
5179ac9
Merge branch 'master' into form_tests
reachaadrika Jul 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/form/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ export default function Select({
selected,
}) {
return (
<select
<select data-testid="Select-form"
onChange={(ev) => onChange(ev.target.value)}
className={twMerge(`form-select h-full py-0 pl-2 pr-8 inline-flex justify-center rounded-md border border-gray-300 shadow-sm px-4 py-2 bg-white text-sm font-medium text-gray-700 hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-offset-gray-100 focus:ring-indigo-500 ${className}`)}
value={selected}
>
{options.map((option, index) => (
<option key={index} selected={option.value === selected} value={option.value}>
<option key={index} selected={option.value === selected} value={option.value} data-testid="Option-form">
{option.text}
</option>
))}
Expand Down
14 changes: 7 additions & 7 deletions components/slack/Message.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ export default function SlackMessage({
reactions = [],
}) {
return (
<div className={`flex pl-2 my-2 text-left ${className}`}>
<img className="block w-9 h-9 mr-2 rounded object-cover" src={avatar} alt={name}/>
<div className={`flex pl-2 my-2 text-left ${className}`} data-testid="SlackMessage-main-div">
<img className="block w-9 h-9 mr-2 rounded object-cover" src={avatar} alt={name} data-testid="SlackMessage-img"/>
<div>
<div className="font-bold text-sm -mt-1">{name}</div>
<p className="text-sm">
<div className="font-bold text-sm -mt-1" data-testid="SlackMessage-name">{name}</div>
<p className="text-sm" data-testid="SlackMessage-text">
{text}
</p>
<div className="mt-0.5">
{
reactions.map((reaction, index) => (
<div key={index} className={`inline px-2 py-0.5 mr-1 rounded-xl ${reaction.mine ? 'bg-blue-50 border border-blue-500' : 'bg-gray-100'}`}>
{ reaction.icon ? (<img className="inline-block -mt-0.5 w-4 h-4 object-contain" src={reaction.icon} alt={reaction.name}/>) : (<span className="text-xs mr-1">{reaction.emoji}</span>) }
<span className="inline-block text-blue-500 font-bold ml-1 text-xs">{reaction.count}</span>
<div key={index} className={`inline px-2 py-0.5 mr-1 rounded-xl ${reaction.mine ? 'bg-blue-50 border border-blue-500' : 'bg-gray-100'}`} data-testid="SlackMessage-reaction">
{ reaction.icon ? (<img className="inline-block -mt-0.5 w-4 h-4 object-contain" src={reaction.icon} alt={reaction.name} data-testid="reactionIcon" />) : (<span className="text-xs mr-1" data-testid="SlackMessage-span">{reaction.emoji}</span>) }
<span className="inline-block text-blue-500 font-bold ml-1 text-xs" data-testid="SlackMessage-count">{reaction.count}</span>
</div>
))
}
Expand Down
2 changes: 1 addition & 1 deletion components/slack/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function Slack({
<div className="mb-1 h-2 rounded-xl bg-white bg-opacity-25 w-1/4"></div>
<div className="mb-1 h-2 rounded-xl bg-white bg-opacity-25 w-1/3"></div>
</div>
<div className="flex-1 py-2">
<div className="flex-1 py-2" data-testid="SlackMessage">
<SlackMessage
avatar="/img/homepage/lukasz-homepage-slack.webp"
name="Lukasz Gornicki"
Expand Down
35 changes: 35 additions & 0 deletions cypress/test/form/Select.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { mount } from 'cypress/react';
import Select from '../../../components/form/Select';

describe('Select Component', () => {
const options = [
{ value: 'option1', text: 'Option 1' },
{ value: 'option2', text: 'Option 2' },
{ value: 'option3', text: 'Option 3' },
];

it('should call onChange when an option is selected', () => {
const onChange = cy.stub().as('onChange');
mount(<Select onChange={onChange} options={options} />);

cy.get('[data-testid="Select-form"]').select('option2');
cy.get('@onChange').should('be.calledOnceWith', 'option2');
});

it('should render options correctly', () => {
mount(<Select options={options} selected="option2" />);

cy.get('[data-testid="Select-form"]')
.find('[data-testid="Option-form"]')
.should(($options) => {
expect($options).to.have.length(3);

const optionValues = $options.map((_, el) => Cypress.$(el).val()).get();
expect(optionValues).to.deep.eq(['option1', 'option2', 'option3']);

const selectedOption = $options.filter(':selected');
expect(selectedOption).to.have.length(1);
expect(selectedOption.text()).to.eq('Option 2');
});
});
});
37 changes: 37 additions & 0 deletions cypress/test/slack/Message.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { mount } from '@cypress/react'
import SlackMessage from '../../../components/slack/Message'
describe('SlackMessage component', () => {
it('renders the SlackMessage component correctly', () => {
const avatarSrc = '../../../public/img/avatars/dalelane.webp' // Replace
const name = 'John Doe'
const text = 'Hello, world!'
const reactions = [
{ emoji: '👍', count: 5 },
{ emoji: '❤️', count: 3 },
// Add more reactions
]

mount(
<SlackMessage avatar={ avatarSrc } name={ name } text={ text } reactions={ reactions } />
)


cy.get('[data-testid="SlackMessage-main-div"]').should('exist')
cy.get('[ data-testid="SlackMessage-img"]').should('have.attr', 'src', avatarSrc)
cy.get('[data-testid="SlackMessage-name"]').should('contain', name)
cy.get('[data-testid="SlackMessage-text"]').should('contain', text)

// Check the reaction elements
reactions.forEach((reaction, index) => {
cy.get('[data-testid="SlackMessage-reaction"]').eq(index).as('reactionElement')

if (reaction.icon) {
cy.get('@reactionElement').find('[data-testid="SlackMessage-reactionIcon"]').should('have.attr', 'src', reaction.icon)
} else {
cy.get('@reactionElement').find('[data-testid="SlackMessage-span"]').should('contain', reaction.emoji)
}

cy.get('@reactionElement').find('[data-testid="SlackMessage-count"]').should('contain', reaction.count)
})
})
})
21 changes: 21 additions & 0 deletions cypress/test/slack/index.cy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import React from 'react';
import { mount } from 'cypress/react';
import Slack from '../../../components/slack/index';

describe('Slack Component', () => {
it('renders the Slack messages correctly', () => {
mount(<Slack />);

// Verify the first Slack message
cy.get('[data-testid="SlackMessage"]').eq(0).as('message-1').should('exist')

// Verify the second Slack message
cy.get('[data-testid="SlackMessage"]').eq(0).as('message-2').should('exist')

// Verify the third Slack message
cy.get('[data-testid="SlackMessage"]').eq(0).as('message-3').should('exist')

// Verify the fourth Slack message
cy.get('[data-testid="SlackMessage"]').eq(0).as('message-4').should('exist')
});
});
Loading