feat: adding unit tests for footer component #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachaadrika
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1809--asyncapi-website.netlify.app/ |
akshatnema
added
the
gsoc
akshatnema
requested changes
Jul 9, 2023
components/footer/FooterList2.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| export const initiativeLinks = [ | |||
There was a problem hiding this comment.
Rename the file to more meaningful name for this array. You can also define this array in FooterList.js.
cypress/test/footer/footer.cy.js
Outdated
| beforeEach(() => { | ||
| mount(<Footer />) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Add a case for checking AsyncAPI logo in footer and the link connected to the logo.
akshatnema
previously approved these changes
Jul 10, 2023
akshatnema
approved these changes
Jul 10, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Footer component previously was a standalone file in the code , with a lot of nested li and div tags for various social media and initiative links , thus to make code more readable and module I created 2 arrays one for initiative links and one for social media links and then rendered the data via map , so now if any new link is to be added to the website footer , one can easily add it to the array .
This was also done so that it is easier for the unit test to function , in the previous code , whenever any new link is added to the website , user would be required to change the test file as well as the code file .
Thus in the new structure I have created a folder "Footer" in the components folder and have modified the necessary imports .
Unit tests for this component are as follows :
Related issue(s)
fixes add unit tests for Footer Component #1808