feat: adding unit tests for button component #1818
Conversation
reachaadrika
requested review from
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1818--asyncapi-website.netlify.app/ |
| ); | ||
| cy.contains('Custom Text').should('be.visible'); | ||
| cy.get('[ data-testid="Button-link"]').should('have.attr', 'href', customHref); | ||
| cy.get('[ data-testid="Button-link"]').should('have.attr', 'target', '_self'); |
There was a problem hiding this comment.
why are you adding space here? between [ data-test @reachaadrika
Please install a formatter extension in your vscode
fix this space issue with all over places
akshatnema
added
the
gsoc
It has button testcases only |
| <GoogleCalendarButton | ||
| text="Custom Text" | ||
| href={customHref} | ||
| target="_self" | ||
| iconPosition="right" | ||
| /> |
There was a problem hiding this comment.
You have mounted wrong component inside ICSFileButton.cy.js test file.
cypress/test/buttons/buttons.cy.js
Outdated
| @@ -0,0 +1,48 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Rename this file to Button.cy.js.
cypress/test/buttons/buttons.cy.js
Outdated
| cy.get('[data-testid="Button-main"]').should('have.attr', 'type', type); | ||
| cy.get('[data-testid="Button-link"]').should('not.exist'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Add a case for testing if icon is not present in Button component.
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
|
/rtm |
Description
For the Main Button component I have included following tests :
Other Button files here are as follows :
For these components the tests that I have included are as follows :
Related issue(s)
fixes #1730