feat: add unit tests for AlgoliaSearch,GeneratorInstallation and OpenAPIComparison component #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reachaadrika
requested review from
derberg,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1916--asyncapi-website.netlify.app/ |
akshatnema
added
the
gsoc
akshatnema
requested changes
Jul 13, 2023
components/OpenAPIComparison.js
Outdated
| <div className="flex-1 border border-black p-2 mr-1"> | ||
| <h3 className="text-lg font-sans font-medium mb-4 ml-2">OpenAPI 3.0</h3> | ||
|
|
||
| <div> | ||
| <div className={(hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2`} onMouseOver={() => setHoverState(prevState => ({ ...prevState, Info: true }))} onMouseLeave={() => setHoverState({ ...hoverState, Info: false })}> | ||
| <div className={ (hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2` } onMouseOver={ () => setHoverState(prevState => ({ ...prevState, Info: true })) } onMouseLeave={ () => setHoverState({ ...hoverState, Info: false }) } data-testid="OpenAPI-sec1"> |
There was a problem hiding this comment.
Suggested change
| <div className={ (hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2` } onMouseOver={ () => setHoverState(prevState => ({ ...prevState, Info: true })) } onMouseLeave={ () => setHoverState({ ...hoverState, Info: false }) } data-testid="OpenAPI-sec1"> | |
| <div className={ (hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2` } onMouseOver={ () => setHoverState(prevState => ({ ...prevState, Info: true })) } onMouseLeave={ () => setHoverState({ ...hoverState, Info: false }) } data-testid="OpenAPI-sec-info"> |
Don't make the test ids as 1,2,3..., use the correct names to identify them easily.
Applicable everywhere.
cypress/test/AlgoliaSearch.cy.js
Outdated
| import AlgoliaSearch from '../../components/AlgoliaSearch' | ||
| describe('AlgoliaSearch component', () => { | ||
| it('renders without errors', () => { | ||
| mount(<AlgoliaSearch />); |
There was a problem hiding this comment.
You have to use SearchButton inside AlgoliaSearch to test the component.
Also, derive a case where it searches for certain page inside docs, by typing it in the search box.
imabp
suggested changes
Jul 14, 2023
components/OpenAPIComparison.js
Outdated
| <div className="flex-1 border border-black p-2 mr-1"> | ||
| <h3 className="text-lg font-sans font-medium mb-4 ml-2">OpenAPI 3.0</h3> | ||
|
|
||
| <div> | ||
| <div className={(hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2`} onMouseOver={() => setHoverState(prevState => ({ ...prevState, Info: true }))} onMouseLeave={() => setHoverState({ ...hoverState, Info: false })}> | ||
| <div className={ (hoverState.Info ? `bg-blue-100 ` : ` `) + `border border-blue-300 p-2 m-2` } onMouseOver={ () => setHoverState(prevState => ({ ...prevState, Info: true })) } onMouseLeave={ () => setHoverState({ ...hoverState, Info: false }) } data-testid="OpenAPI-sec1"> |
|
@reachaadrika Kindly resolve the conflicts in this. |
akshatnema
changed the title
@akshatnema resolved |
akshatnema
reviewed
Jul 17, 2023
|
|
||
| cy.get('input[placeholder="Search resources"]').type('welcome') | ||
| cy.should('have.value', 'welcome') | ||
| }); |
There was a problem hiding this comment.
Add the check of getting Welcome inside the docsearch-list ul list of DOM.
akshatnema
approved these changes
Jul 17, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AlgoliaSearch : This is the search component for website .
GeneratorInstallation : This generates the content for the editor component .
OpenAPIComparison : This component is part of the Docs Layout and I have tested for hover and matching colors of the component .
Related issue(s)
fixes #1915