Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Maya as code owner #1931

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Jul 11, 2023

Closes #1905

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit ec14d8b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64aebf7be214a80008fb9269
😎 Deploy Preview https://deploy-preview-1931--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1931--asyncapi-website.netlify.app/

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas are we making Maya CODEOWNER for README file only?

@derberg
Copy link
Member

derberg commented Jul 12, 2023

technically she should be explicitly like others for readme, but @fmvilas please update and add her to line 8 too. Just like it was with Missy -> https://github.com/asyncapi/website/pull/1904/files

@fmvilas
Copy link
Member Author

fmvilas commented Jul 12, 2023

@akshatnema Yeah, why not? 😂 Sorry, was a mistake. Fixing it!

@fmvilas
Copy link
Member Author

fmvilas commented Jul 12, 2023

@akshatnema @derberg Done! 👍

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! No objections in #1905

@Mayaleeeee you should get a GitHub invite pretty soon, to become maintainer of the repo

because you became a maintainer of AsyncAPI repository, in this case website, I'd like to invite you to join AsyncAPI TSC where you can be active on a wider spectrum of the AsyncAPI Initiative. Because you already contributed to the initiative, even as active person in voting that you did not have to join, a assume already that you'd like to become TSC member.

To add yourself to TSC list, please add your name and all the details to https://github.com/asyncapi/community/blob/master/MAINTAINERS.yaml and of course lemme know if I can help in anyway

@derberg
Copy link
Member

derberg commented Jul 12, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit d7973fb into asyncapi:master Jul 12, 2023
11 checks passed
@fmvilas fmvilas deleted the add-maya-as-codeowner branch July 12, 2023 16:41
@Mayaleeeee
Copy link
Member

Thank you sooooo much folks🥳🥳🥳🥰🥰❤️😍
I won't take this for granted 💯💯🙏

@Mayaleeeee
Copy link
Member

All good! No objections in #1905

@Mayaleeeee you should get a GitHub invite pretty soon, to become maintainer of the repo

because you became a maintainer of AsyncAPI repository, in this case website, I'd like to invite you to join AsyncAPI TSC where you can be active on a wider spectrum of the AsyncAPI Initiative. Because you already contributed to the initiative, even as active person in voting that you did not have to join, a assume already that you'd like to become TSC member.

To add yourself to TSC list, please add your name and all the details to https://github.com/asyncapi/community/blob/master/MAINTAINERS.yaml and of course lemme know if I can help in anyway

I'm gonna to that very soon.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Designer maintainer for website
5 participants