Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete monaco dependency #1973

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ThaungThanHan
Copy link
Contributor

Description

Related issue(s)

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69a61f7
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b8dbc3b4d25a0008b79113
😎 Deploy Preview https://deploy-preview-1973--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ThaungThanHan ThaungThanHan changed the title Chores!: Uninstalled monaco chore: uninstalled monaco Jul 20, 2023
@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1973--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Jul 20, 2023

@ThaungThanHan do a npm i and then push packagelock.json

@ThaungThanHan
Copy link
Contributor Author

@sambhavgupta0705 Both packages are fully removed.

@sambhavgupta0705
Copy link
Member

Great .We are good to go then

@sambhavgupta0705
Copy link
Member

@ThaungThanHan link the related issue in the description

@derberg derberg changed the title chore: uninstalled monaco chore: remove obsolete monaco dependency Jul 20, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@derberg
Copy link
Member

derberg commented Jul 20, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 5d0a854 into asyncapi:master Jul 20, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @monaco-editor/react and @monaco-editor from package.json
4 participants