Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add document for adding channel #2408

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Dec 8, 2023

Description
Added Adding channel page.

It is a part of GSoD'23 project.

Related issue(s): #1510

Previously worked PR: #1929

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a61980
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6578c5d2517ca00008da0e20
😎 Deploy Preview https://deploy-preview-2408--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mhmohona
Copy link
Contributor Author

mhmohona commented Dec 8, 2023

The PR will pass Lighthouse CI / Lighthouse CI test once #1927 PR is merged.

@derberg derberg changed the title docs: adding document for adding channel docs: add document for adding channel Dec 12, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli another for review. I changed a lot so you need to do another review, like with other documents

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 12, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 52
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2408--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ca15e1b into asyncapi:master Dec 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants