Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added test for build-rss.js #3101

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
63e8bf5
added test for build-rss.js
vishvamsinh28 Jul 21, 2024
c2570b9
Merge branch 'master' into rssTest
asyncapi-bot Aug 11, 2024
30f1c7f
Merge branch 'master' into rssTest
vishvamsinh28 Aug 16, 2024
aad7bf2
test updated
vishvamsinh28 Aug 16, 2024
312d4c5
Merge branch 'master' into rssTest
anshgoyalevil Aug 18, 2024
8d7269a
Merge branch 'master' into rssTest
vishvamsinh28 Aug 22, 2024
cfd547f
fewe
vishvamsinh28 Aug 22, 2024
5859c79
fedge
vishvamsinh28 Aug 22, 2024
44c3b63
fsfa
vishvamsinh28 Aug 22, 2024
de5edec
test for write operation error
vishvamsinh28 Aug 22, 2024
bf10b10
test updated
vishvamsinh28 Aug 22, 2024
1bacff6
egrwsdb
vishvamsinh28 Aug 22, 2024
3ce90ca
Merge branch 'master' into rssTest
vishvamsinh28 Aug 26, 2024
5d8fb67
use pretteir for rssData
vishvamsinh28 Aug 31, 2024
198c2a4
Merge branch 'master' into rssTest
anshgoyalevil Sep 5, 2024
5f4d05b
Merge branch 'master' into rssTest
asyncapi-bot Sep 5, 2024
5ab37aa
Merge branch 'master' into rssTest
vishvamsinh28 Sep 7, 2024
81b9845
Merge branch 'master' into rssTest
vishvamsinh28 Sep 11, 2024
92e86a3
Merge branch 'rssTest' of https://github.com/vishvamsinh28/website in…
vishvamsinh28 Sep 11, 2024
0d0cb30
updated rss mock data
vishvamsinh28 Sep 11, 2024
d7e0ac1
updated rss test
vishvamsinh28 Sep 11, 2024
fc57c2a
udadw
vishvamsinh28 Sep 11, 2024
1a8aa47
updated imports
vishvamsinh28 Sep 11, 2024
5ddb184
test updated
vishvamsinh28 Sep 11, 2024
5e8c0c7
Merge branch 'master' into rssTest
anshgoyalevil Sep 13, 2024
1eb6790
added try catch block for tests
vishvamsinh28 Sep 13, 2024
b03191d
Merge branch 'master' into rssTest
vishvamsinh28 Sep 15, 2024
239e65b
Merge branch 'master' into rssTest
vishvamsinh28 Sep 16, 2024
5e98d50
removed try catch block
vishvamsinh28 Sep 16, 2024
45f6ef6
Merge branch 'rssTest' of https://github.com/vishvamsinh28/website in…
vishvamsinh28 Sep 16, 2024
e6258c5
replaced trown with console.error
vishvamsinh28 Sep 16, 2024
7c9730f
using promise for throwign errors
vishvamsinh28 Sep 16, 2024
6e9f039
add error variable
vishvamsinh28 Sep 16, 2024
aac6e13
updated the test for rss
vishvamsinh28 Sep 16, 2024
0f61abe
Merge branch 'master' into rssTest
vishvamsinh28 Sep 20, 2024
e06fa47
updated test
vishvamsinh28 Sep 20, 2024
bc67c28
Merge branch 'master' into rssTest
anshgoyalevil Sep 23, 2024
8c93997
fwwfwf
vishvamsinh28 Sep 23, 2024
6e0b4ce
revert getAllPosts func changes
anshgoyalevil Sep 23, 2024
2631dc6
Merge branch 'master' into rssTest
vishvamsinh28 Sep 26, 2024
a66f2a2
Merge branch 'master' into rssTest
vishvamsinh28 Sep 28, 2024
a51c362
wsff
vishvamsinh28 Sep 28, 2024
4eb10e3
fefe
vishvamsinh28 Sep 28, 2024
4e75b0a
added test cases for errors
vishvamsinh28 Sep 28, 2024
5892f1e
Merge branch 'master' into rssTest
vishvamsinh28 Sep 30, 2024
e04cfba
Merge branch 'master' into rssTest
vishvamsinh28 Oct 4, 2024
07b2344
Merge branch 'master' into rssTest
vishvamsinh28 Oct 7, 2024
d55f553
suggested changes applied
vishvamsinh28 Oct 7, 2024
d9585fe
Merge branch 'master' into rssTest
vishvamsinh28 Oct 12, 2024
d41b851
Merge branch 'master' into rssTest
vishvamsinh28 Oct 13, 2024
d5b6882
empty line at end
vishvamsinh28 Oct 13, 2024
7980458
Merge branch 'rssTest' of https://github.com/vishvamsinh28/website in…
vishvamsinh28 Oct 13, 2024
6a93919
Merge branch 'master' into rssTest
vishvamsinh28 Oct 14, 2024
a5c083b
Merge branch 'master' into rssTest
vishvamsinh28 Oct 15, 2024
49f308a
replaced throw with promise.reject
vishvamsinh28 Oct 17, 2024
a4903ef
Merge branch 'master' into rssTest
vishvamsinh28 Oct 17, 2024
1ab85ee
Merge branch 'master' into rssTest
vishvamsinh28 Oct 20, 2024
36e7511
Merge branch 'master' into rssTest
anshgoyalevil Oct 23, 2024
1d39693
Merge branch 'master' into rssTest
vishvamsinh28 Oct 23, 2024
8a55fa2
test updated
vishvamsinh28 Oct 23, 2024
2ee9f6f
test updted
vishvamsinh28 Oct 23, 2024
6804d6e
rwwq
vishvamsinh28 Oct 23, 2024
fd0bb07
removed try/catch
vishvamsinh28 Oct 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 52 additions & 49 deletions scripts/build-rss.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,60 +16,63 @@ function clean(s) {
}

module.exports = function rssFeed(type, title, desc, outputPath) {
try {
const posts = getAllPosts()[`${type}`]
.sort((i1, i2) => {
const i1Date = new Date(i1.date)
const i2Date = new Date(i2.date)

const posts = getAllPosts()[`${type}`]
.sort((i1, i2) => {
const i1Date = new Date(i1.date)
const i2Date = new Date(i2.date)
if (i1.featured && !i2.featured) return -1
if (!i1.featured && i2.featured) return 1
return i2Date - i1Date
})

if (i1.featured && !i2.featured) return -1
if (!i1.featured && i2.featured) return 1
return i2Date - i1Date
})
const base = 'https://www.asyncapi.com'
const tracking = '?utm_source=rss';

const base = 'https://www.asyncapi.com'
const tracking = '?utm_source=rss';
const feed = {}
const rss = {}
rss['@version'] = '2.0'
rss["@xmlns:atom"] = 'http://www.w3.org/2005/Atom'
rss.channel = {}
rss.channel.title = title
rss.channel.link = `${base}/${outputPath}`
rss.channel["atom:link"] = {}
rss.channel["atom:link"]["@rel"] = 'self'
rss.channel["atom:link"]["@href"] = rss.channel.link
rss.channel["atom:link"]["@type"] = 'application/rss+xml'
rss.channel.description = desc
rss.channel.language = 'en-gb';
rss.channel.copyright = 'Made with :love: by the AsyncAPI Initiative.';
rss.channel.webMaster = '[email protected] (AsyncAPI Initiative)'
rss.channel.pubDate = new Date().toUTCString()
rss.channel.generator = 'next.js'
rss.channel.item = []

const feed = {}
const rss = {}
rss['@version'] = '2.0'
rss["@xmlns:atom"] = 'http://www.w3.org/2005/Atom'
rss.channel = {}
rss.channel.title = title
rss.channel.link = `${base}/${outputPath}`
rss.channel["atom:link"] = {}
rss.channel["atom:link"]["@rel"] = 'self'
rss.channel["atom:link"]["@href"] = rss.channel.link
rss.channel["atom:link"]["@type"] = 'application/rss+xml'
rss.channel.description = desc
rss.channel.language = 'en-gb';
rss.channel.copyright = 'Made with :love: by the AsyncAPI Initiative.';
rss.channel.webMaster = '[email protected] (AsyncAPI Initiative)'
rss.channel.pubDate = new Date().toUTCString()
rss.channel.generator = 'next.js'
rss.channel.item = []

for (let post of posts) {
const link = `${base}${post.slug}${tracking}`;
const item = { title: post.title, description: clean(post.excerpt), link, category: type, guid: { '@isPermaLink': true, '': link }, pubDate: new Date(post.date).toUTCString() }
if (post.cover) {
const enclosure = {};
enclosure["@url"] = base+post.cover;
enclosure["@length"] = 15026; // dummy value, anything works
enclosure["@type"] = 'image/jpeg';
if (typeof enclosure["@url"] === 'string') {
let tmp = enclosure["@url"].toLowerCase();
if (tmp.indexOf('.png')>=0) enclosure["@type"] = 'image/png';
if (tmp.indexOf('.svg')>=0) enclosure["@type"] = 'image/svg+xml';
if (tmp.indexOf('.webp')>=0) enclosure["@type"] = 'image/webp';
for (let post of posts) {
const link = `${base}${post.slug}${tracking}`;
const item = { title: post.title, description: clean(post.excerpt), link, category: type, guid: { '@isPermaLink': true, '': link }, pubDate: new Date(post.date).toUTCString() }
if (post.cover) {
const enclosure = {};
enclosure["@url"] = base + post.cover;
enclosure["@length"] = 15026; // dummy value, anything works
enclosure["@type"] = 'image/jpeg';
if (typeof enclosure["@url"] === 'string') {
let tmp = enclosure["@url"].toLowerCase();
if (tmp.indexOf('.png') >= 0) enclosure["@type"] = 'image/png';
if (tmp.indexOf('.svg') >= 0) enclosure["@type"] = 'image/svg+xml';
if (tmp.indexOf('.webp') >= 0) enclosure["@type"] = 'image/webp';
}
item.enclosure = enclosure;
Comment on lines +75 to +86
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use mime-types package for better image type detection

Replace manual image type detection with the mime-types package:

+const mime = require('mime-types');

if (post.cover) {
  const enclosure = {};
  enclosure["@url"] = base + post.cover;
  enclosure["@length"] = 15026;
-  enclosure["@type"] = 'image/jpeg';
-  if (typeof enclosure["@url"] === 'string') {
-    let tmp = enclosure["@url"].toLowerCase();
-    if (tmp.indexOf('.png') >= 0) enclosure["@type"] = 'image/png';
-    if (tmp.indexOf('.svg') >= 0) enclosure["@type"] = 'image/svg+xml';
-    if (tmp.indexOf('.webp') >= 0) enclosure["@type"] = 'image/webp';
-  }
+  enclosure["@type"] = mime.lookup(post.cover) || 'image/jpeg';

Committable suggestion was skipped due to low confidence.

}
item.enclosure = enclosure;
rss.channel.item.push(item)
}
rss.channel.item.push(item)
}

feed.rss = rss
feed.rss = rss

const xml = json2xml.getXml(feed,'@','',2)
fs.writeFileSync(`./public/${outputPath}`, xml, 'utf8')
};
const xml = json2xml.getXml(feed, '@', '', 2)
fs.writeFileSync(`./public/${outputPath}`, xml, 'utf8')
} catch (err) {
throw new Error(`Failed to generate RSS feed: ${err.message}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of throwing error, can we return error as promise?

@vishvamsinh28 @anshgoyalevil

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are processing the script synchronously, so returning a promise wouldn't be appropriate here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching of error doesn't depend on whether the function is synchronous or asynchronous. It will still return the error, based on the function return type.

}
};
81 changes: 81 additions & 0 deletions tests/build-rss.test.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, add the scenarios where the function should actually lead to an error, instead of executing it perfectly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishvamsinh28 @anshgoyalevil Comment not addressed

Copy link
Contributor Author

@vishvamsinh28 vishvamsinh28 Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add more tests for it. 👍 I can add a test to check if the user doesn't have a posts.json file, but for that, I'll have to temporarily rename the file. Should I add that test?

Copy link
Member

@akshatnema akshatnema Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, consider a scenario if data inside posts.json is in wrong manner. Then it should return error, right? Make the tests for those cases as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatnema updated the test

Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
const fs = require('fs');
const path = require('path');
const rssFeed = require('../scripts/build-rss');
const { mockRssData, title, type, desc, outputPath } = require('./fixtures/rssData');

jest.mock('../config/posts.json', () => mockRssData, { virtual: true });

describe('rssFeed', () => {
const testOutputDir = path.join(__dirname, '..', 'public', 'test-output');

beforeEach(() => {
fs.mkdirSync(testOutputDir, { recursive: true });
});

afterEach(() => {
if (fs.existsSync(testOutputDir)) {
fs.readdirSync(testOutputDir).forEach(file => {
fs.unlinkSync(path.join(testOutputDir, file));
});
fs.rmdirSync(testOutputDir);
}
});

it('should generate RSS feed and write to file', () => {
rssFeed(type, title, desc, outputPath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a try/catch block here to track the err variable here and see if any error is not returned from function execution? Try to do it for each test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


const filePath = path.join(__dirname, '..', 'public', outputPath);
expect(fs.existsSync(filePath)).toBe(true);
const fileContent = fs.readFileSync(filePath, 'utf8');
expect(fileContent).toContain('<rss version="2.0"');
expect(fileContent).toContain('<title>Test Blog RSS</title>');
});

it('should sort posts by date and featured status', () => {
rssFeed(type, title, desc, outputPath);

const filePath = path.join(__dirname, '..', 'public', outputPath);
const fileContent = fs.readFileSync(filePath, 'utf8');

const itemTitles = fileContent.match(/<title>(.*?)<\/title>/g);
expect(itemTitles[1]).toContain('Test Post 1');
expect(itemTitles[2]).toContain('Test Post 2');
expect(itemTitles[3]).toContain('PNG Post');
expect(itemTitles[4]).toContain('SVG Post');
expect(itemTitles[5]).toContain('WebP Post');
});

it('should add enclosure for posts with cover image', () => {
rssFeed(type, title, desc, outputPath);

const filePath = path.join(__dirname, '..', 'public', outputPath);
const fileContent = fs.readFileSync(filePath, 'utf8');

expect(fileContent).toContain('<enclosure url="https://www.asyncapi.com/img/test-cover.jpg"');
expect(fileContent).toContain('type="image/jpeg"');
});

it('should set correct enclosure type based on image extension', () => {
rssFeed(type, title, desc, outputPath);

const filePath = path.join(__dirname, '..', 'public', outputPath);
const fileContent = fs.readFileSync(filePath, 'utf8');

expect(fileContent).toContain('<enclosure url="https://www.asyncapi.com/img/test-cover.png"');
expect(fileContent).toContain('type="image/png"');
expect(fileContent).toContain('<enclosure url="https://www.asyncapi.com/img/test-cover.svg"');
expect(fileContent).toContain('type="image/svg+xml"');
expect(fileContent).toContain('<enclosure url="https://www.asyncapi.com/img/test-cover.webp"');
expect(fileContent).toContain('type="image/webp"');
});

it('should throw error when write operation fails', () => {
const outputPath = "invalid/path"
try{
rssFeed(type, title, desc, outputPath)
}catch(err){
expect(err.message).toMatch(/ENOENT|EACCES/);
}
});

});
50 changes: 50 additions & 0 deletions tests/fixtures/rssData.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not following eslint rules inside this file? I see lot of indentation spaces here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not getting any lint errors locally, and I have removed unnecessary indentation in previous commits.

Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
const mockRssData = {
blog: [
{
title: 'Test Post 1',
slug: '/blog/test-post-1',
excerpt: 'This is a test post',
date: '2024-07-07',
featured: true,
cover: '/img/test-cover.jpg'
},
{
title: 'Test Post 2',
slug: '/blog/test-post-2',
excerpt: 'This is another test post',
date: '2024-07-06',
featured: false
},
{
title: 'PNG Post',
slug: '/blog/png-post',
excerpt: 'This is a post with PNG image',
date: '2024-07-05',
featured: false,
cover: '/img/test-cover.png'
},
{
title: 'SVG Post',
slug: '/blog/svg-post',
excerpt: 'This is a post with SVG image',
date: '2024-07-04',
featured: false,
cover: '/img/test-cover.svg'
},
{
title: 'WebP Post',
slug: '/blog/webp-post',
excerpt: 'This is a post with WebP image',
date: '2024-07-03',
featured: false,
cover: '/img/test-cover.webp'
}
]
};

const type = 'blog';
const title = 'Test Blog RSS';
const desc = 'Test blog RSS feed';
const outputPath = 'test-output/blog.xml';

module.exports = { mockRssData, title, type, desc, outputPath };
Loading