-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests for tool-object script #3265
Open
vishvamsinh28
wants to merge
41
commits into
asyncapi:master
Choose a base branch
from
vishvamsinh28:toolsObjectTest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+542
−160
Open
Changes from 14 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
d1fc6c4
tests added
vishvamsinh28 9b22bc1
fwqfwq
vishvamsinh28 3629568
fefeq
vishvamsinh28 cabfbae
errors added
vishvamsinh28 340c1f7
fixture update
vishvamsinh28 5d4771b
fwqf
vishvamsinh28 7673203
Merge branch 'master' into toolsObjectTest
vishvamsinh28 e6a3505
Merge branch 'master' into toolsObjectTest
vishvamsinh28 403bb4e
wfwqf
vishvamsinh28 9d74152
fwgff
vishvamsinh28 3e20593
updated test for errors
vishvamsinh28 5000a47
updated test for errors
vishvamsinh28 8efbc84
Merge branch 'master' into toolsObjectTest
vishvamsinh28 56b0fdd
renamed a variabel
vishvamsinh28 859676e
Merge branch 'master' into toolsObjectTest
vishvamsinh28 f51feb3
test updated
vishvamsinh28 f540e5b
Merge branch 'master' into toolsObjectTest
vishvamsinh28 ae3e19b
Merge branch 'master' into toolsObjectTest
vishvamsinh28 3e73220
path update
vishvamsinh28 f9906ae
Merge branch 'toolsObjectTest' of https://github.com/vishvamsinh28/we…
vishvamsinh28 d31a06f
commit to rerun workflow
vishvamsinh28 03f9dc1
commit to rerun workflow
vishvamsinh28 c866aa0
Merge branch 'master' into toolsObjectTest
vishvamsinh28 bfc9e6e
fefewg
vishvamsinh28 9c1ef9e
supress logs
vishvamsinh28 a1af4f7
newsroom test update
vishvamsinh28 9d38d41
build-tools test update
vishvamsinh28 08a8970
uupdate newsroom function
vishvamsinh28 cb90254
update build-tools function
vishvamsinh28 d16f9a1
commit to re run the workflow
vishvamsinh28 1164703
Merge branch 'master' into toolsObjectTest
vishvamsinh28 4540530
added retry mechanicasm for enoent errors
vishvamsinh28 cf6a37d
Merge branch 'toolsObjectTest' of https://github.com/vishvamsinh28/we…
vishvamsinh28 0a83f54
fegwg
vishvamsinh28 740d4d6
fwqfqf
vishvamsinh28 8f2162d
feeqg
vishvamsinh28 c2ee924
use fs-extra
vishvamsinh28 267023e
commit to re run the workflow
vishvamsinh28 e4be92f
fqefeqf
vishvamsinh28 f39e57c
Merge branch 'master' into toolsObjectTest
vishvamsinh28 dcb955b
test updated
vishvamsinh28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,4 +86,5 @@ describe('buildTools', () => { | |
expect(err.message).toMatch(/ENOENT|EACCES/); | ||
} | ||
}); | ||
|
||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance the file write error test case
The new test case for handling file write errors is a valuable addition. However, consider the following improvements to make it more robust and comprehensive:
Here's a suggested improvement:
This improved version:
err.code
instead oferr.message
for more specific error checking.fail()
to ensure an error is thrown.