Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text thickness and add mirrored #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tannewt
Copy link

@tannewt tannewt commented Jun 13, 2023

No description provided.

kicad/pcbnew/drawing.py Outdated Show resolved Hide resolved
@xeokeri
Copy link

xeokeri commented Sep 28, 2023

Any update on this getting merged in? As I've been running into the exception with the SetThickness when using KiCad 7.x.

@4rzael
Copy link

4rzael commented Oct 6, 2023

I'm actually also getting the AttributeError: 'PCB_TEXT' object has no attribute 'SetThickness' error on KiCad 6 (specifically: (6.0.6-1)-1) on MacOS.

I checked, and SWIG_version is indeed 6 on my setup.
Changing SetThickness to SetTextThickness works.
I'd thus recommend changing this PR's references to if SWIG_version >= 7 to if SWIG_version >= 6.

Also, is there anything else blocking this PR from getting merged ? If so, I'm up to work on it.

@atait
Copy link
Owner

atait commented Jan 30, 2024

I like this change. Sorry I overlooked it for a while. mirrored will be a good addition, and the >=6 bug is still in there. There is some refactoring going on now, so the location of these edits moved to item.py:TextEsque. @tannewt , it is probably easiest to make a new PR based off of a fresh main branch. I will keep an eye out for one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants